Update Service Fabric version guidance for the lowered dependency floor - #189
Open
tillig wants to merge 1 commit into
Open
Update Service Fabric version guidance for the lowered dependency floor#189tillig wants to merge 1 commit into
tillig wants to merge 1 commit into
Conversation
autofac/Autofac.ServiceFabric#71 changes the integration to reference the oldest supported Service Fabric SDK instead of the newest, so consumers are no longer forced onto the version the package was built against. The advice to match that version is now wrong. Explain instead that consumers pick their own Service Fabric version and only need to keep their own references consistent with each other, note the consequence of not referencing them at all, and record why building against an older SDK than you run against is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #188. Merge this with the Autofac.ServiceFabric 5.0.0 release, not before — it describes behavior that ships in autofac/Autofac.ServiceFabric#71.
Why
#188 told consumers to keep their Service Fabric packages "on the same version as the one
Autofac.ServiceFabricdepends on." That was accurate at the time, but autofac/Autofac.ServiceFabric#71 lowers the integration's dependency floor to the oldest supported SDK precisely so consumers aren't pinned to our version. The old advice becomes wrong.What changed
NU1608. The example warning is kept, since it's still exactly what a mismatch looks like.Verification
doc8clean. Fullsphinx -b htmlbuild succeeds and the new content renders. The only warnings are the two pre-existingunknown document: '../troubleshooting/diagnostics'references infaq/container-analysis.rstandlifetime/disposal.rst.